You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/04/06 08:10:36 UTC

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17174


Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................

IMPALA-10600: Provide fewer details in logs

The impalaD logs contain too much unnecessary information.
This patch hides some fields of RPC requests.

This patch also tries to prevent logging these fields in the
future by:
 * using template metaprogramming to raise compile-time errors
 * updating critique-gerrit-review.py to look for the string
   'ThriftDebugString'

Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
---
M be/src/catalog/catalog-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
M bin/jenkins/critique-gerrit-review.py
4 files changed, 186 insertions(+), 41 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/17174/7
-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8504/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:30:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:37:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 14:21:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................

IMPALA-10600: Provide fewer details in logs

The impalaD logs contain too much unnecessary information.
This patch hides some fields of RPC requests.

This patch also tries to prevent logging these fields in the
future by:
 * using template metaprogramming to raise compile-time errors
 * updating critique-gerrit-review.py to look for the string
   'ThriftDebugString'

Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Reviewed-on: http://gerrit.cloudera.org:8080/17174
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
M bin/jenkins/critique-gerrit-review.py
4 files changed, 186 insertions(+), 41 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:38:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7046/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:38:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10600: Provide fewer details in logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17174 )

Change subject: IMPALA-10600: Provide fewer details in logs
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17174/7/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:

http://gerrit.cloudera.org:8080/#/c/17174/7/bin/jenkins/critique-gerrit-review.py@196
PS7, Line 196:  
flake8: E202 whitespace before '}'



-- 
To view, visit http://gerrit.cloudera.org:8080/17174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f522f458ca399b48d39a1e722421e6248948c6b
Gerrit-Change-Number: 17174
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:11:20 +0000
Gerrit-HasComments: Yes