You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dpitera <gi...@git.apache.org> on 2017/04/06 17:10:18 UTC

[GitHub] tinkerpop pull request #597: TINKERPOP-1666 YAML file supplied to FileSandbo...

GitHub user dpitera opened a pull request:

    https://github.com/apache/tinkerpop/pull/597

    TINKERPOP-1666 YAML file supplied to FileSandboxExtension can have empty staticVariableTypes

    Check if variable is null to avoid NPE
    
    If staticVariableTypes is an empty list in the YAML file, then we throw
    an NPE by trying to run collectEntries() on a null object or trying to
    run containsKey() on a null object.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpitera/tinkerpop TINKERPOP-1666

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #597
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    Next time please consider doing a `git rebase` as opposed to a `git merge` so we don't get the extra merge commit into your PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #597: TINKERPOP-1666 YAML file supplied to FileSandbo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/597


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by dpitera <gi...@git.apache.org>.
Github user dpitera commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    Fixed all that you asked and supplied a Unit Test 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by dpitera <gi...@git.apache.org>.
Github user dpitera commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    Yeah I agree 100%-- I used the UI and didn't realize it would do it like that. I can fix manually if you'd like


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    Looks good
    VOTE: +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    need one more review on this one - any committers available to help out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    that would be nice if you could correct it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    Docker build with `docker/build.sh -t -n -i` was successful. Code and unit tests look fine.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    I wonder why I never noticed this as a problem. This could be targeted at `tp32` branch, right? also would you mind pasting the URL of the JIRA into your pull request comment - we try to do that for all PRs for convenience of reviewers.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by dpitera <gi...@git.apache.org>.
Github user dpitera commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #597: TINKERPOP-1666 YAML file supplied to FileSandboxExtens...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/597
  
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---