You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/19 12:00:57 UTC
[jira] [Created] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Ivan Kelly created BOOKKEEPER-470:
-------------------------------------
Summary: Possible infinite loop in simple.SubscribeReconnectCallback
Key: BOOKKEEPER-470
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
SubscribeReconnectCallback#operationFailed calls
SubscribeReconnectCallback#retrySubscribeRequest calls
channelManager#submitOpAfterDelay calls
SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508622#comment-13508622 ]
Ivan Kelly commented on BOOKKEEPER-470:
---------------------------------------
Resubscribe until success isn't a problem. The problem here is that there's a tight loop, so this will overflow the stack.
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-470
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-470:
---------------------------------
Attachment: BOOKKEEPER-470.diff
added a patch to stop retrying resubscribe if the channel manager is closed. after this patch, it would also resolve the issue described in BOOKKEEPER-489.
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-470
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch, BOOKKEEPER-470.diff
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509837#comment-13509837 ]
Ivan Kelly commented on BOOKKEEPER-470:
---------------------------------------
+1 on the change. will test and push it in.
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-470
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch, BOOKKEEPER-470.diff
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-470:
----------------------------------
Attachment: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch
This is a preliminary patch, though I don't know if it's sufficient. [~hustlmsp] Could you take a look at this when you get a chance?
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-470
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-470) Possible infinite loop in
simple.SubscribeReconnectCallback
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504310#comment-13504310 ]
Sijie Guo commented on BOOKKEEPER-470:
--------------------------------------
I think the behavior before BOOKKEEPER-70 is that we should do resubscribe until succeed if resubscribe is enabled. If you stopped resubscribing, the subscriber got nothing notified about its subscription is stopped unless it registered listener about it. So I think we should keep this behavior but log some critical messages after a specific retires.
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-470
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira