[GitHub] [fineract] ptuomola commented on a change in pull request #1049: FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob

[GitBox <gi...@apache.org>]

ptuomola commented on a change in pull request #1049:
URL: https://github.com/apache/fineract/pull/1049#discussion_r439763780



##########
File path: fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
##########
@@ -229,7 +229,7 @@ public void applyAnnualFeeForSavings() {
                     LOG.error("Apply annual fee failed for account: {} with message {}", savingsAccountReference.getAccountNo(), error);
                 }
             } catch (final Exception ex) {
-                // need to handle this scenario
+                LOG.error("Apply annual fee failed for account: {} with message: {}", savingsAccountReference.getAccountNo(), ex.getMessage());
             }

Review comment:
       I was thinking that if we have scheduled jobs processing large quantities of accounts, we may not want to have the full stack trace for every account - one line per account with the account number and error message would be enough. But will change this to print the full cause...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org