[GitHub] [spark] beliefer commented on a change in pull request #31272: [SPARK-31634][SQL] "show tables like" support for SQL wildcard characters (% and _)

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #31272:
URL: https://github.com/apache/spark/pull/31272#discussion_r562392837



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -60,10 +60,16 @@ object StringUtils extends Logging {
         case c if c == escapeChar => fail("it is not allowed to end with the escape character")
         case '_' => out ++= "."
         case '%' => out ++= ".*"
+        case '*' if filterPattern => out ++= ".*"
+        case '.' if filterPattern => out ++= "."

Review comment:
       The title of this PR seems to support for SQL wildcard characters (% and _) , why we added '*' and '.' ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org