You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/01/02 14:09:01 UTC

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 )

Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14517/4/java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java:

PS4: 
can you add test cases to cover all dates from the C++ client to make sure they're converted to dates the same way?



-- 
To view, visit http://gerrit.cloudera.org:8080/14517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a09f4f9c804c1b2965e78da78528225a9c769e2
Gerrit-Change-Number: 14517
Gerrit-PatchSet: 9
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 14:09:01 +0000
Gerrit-HasComments: Yes