You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/02 06:03:01 UTC
Review Request 67798: Added "old" cli to the cmake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description
-------
This patch adds the "old" cli to the cmake build. We generate a binary
`mesos` unless the new cli is built; in that case we create a binary
`mesos-old`.
Diffs
-----
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
Diff: https://reviews.apache.org/r/67798/diff/1/
Testing
-------
* `cmake -GNinja .. && ninja && ./src/mesos`
* `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
Thanks,
Benjamin Bannier
Re: Review Request 67798: Added "old" cli to the cmake build.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205620
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On July 2, 2018, 6:03 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67798/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 6:03 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the "old" cli to the cmake build. We generate a binary
> `mesos` unless the new cli is built; in that case we create a binary
> `mesos-old`.
>
>
> Diffs
> -----
>
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
>
>
> Diff: https://reviews.apache.org/r/67798/diff/1/
>
>
> Testing
> -------
>
> * `cmake -GNinja .. && ninja && ./src/mesos`
> * `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67798: Added "old" cli to the cmake build.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205627
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67798']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67798
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67798/logs/mesos-tests-stdout.log):
```
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (53 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (57 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (113 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1717 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (1740 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2471 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2493 ms total)
[----------] Global test environment tear-down
[==========] 994 tests from 98 test cases ran. (737915 ms total)
[ PASSED ] 991 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] DockerTest.ROOT_DOCKER_interface
[ FAILED ] DockerTest.ROOT_DOCKER_kill
[ FAILED ] DockerTest.ROOT_DOCKER_CheckPortResource
3 FAILED TESTS
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67798/logs/mesos-tests-stderr.log):
```
I0702 08:20:24.470224 20380 slave.cpp:3939] Shutting down framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000
I0702 08:20:24.470224 23020 master.cpp:11032] Updating the state of task 66c44447-e581-495a-a6ee-0e33a55dc1c4 of framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0702 08:20:24.471209 20380 slave.cpp:6660] Shutting down executor '66c44447-e581-495a-a6ee-0e33a55dc1c4' of framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000 at executor(1)@192.10.1.6:63831
I0702 08:20:24.472204 20380 slave.cpp:931] Agent terminating
W0702 08:20:24.473212 20380 slave.cpp:3935] Ignoring shutdown framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000 because it is terminating
I0702 08:20:24.474212 23020 master.cpp:11131] Removing task 66c44447-e581-495a-a6ee-0e33a55dc1c4 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000 on agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0 at slave(449)@192.10.1.6:63810 (windows-02.enofukwu14I0702 08:20:24.092247 20500 exec.cpp:162] Version: 1.7.0
I0702 08:20:24.129238 10640 exec.cpp:236] Executor registered on agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0
I0702 08:20:24.135241 21672 executor.cpp:182] Received SUBSCRIBED event
I0702 08:20:24.139240 21672 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0702 08:20:24.139240 21672 executor.cpp:182] Received LAUNCH event
I0702 08:20:24.144256 21672 executor.cpp:679] Starting task 66c44447-e581-495a-a6ee-0e33a55dc1c4
I0702 08:20:24.225229 21672 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0702 08:20:24.435210 21672 executor.cpp:693] Forked command at 21572
I0702 08:20:24.473212 20944 exec.cpp:445] Executor asked to shutdown
I0702 08:20:24.476209 21672 executor.cpp:182] Received SHUTDOWN event
I0702 08:20:24.476209 21672 executor.cpp:796] Shutting down
I0702 08:20:24.476209 21672 executor.cpp:909] Sending SIGTERM to process tree at pid 21ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0702 08:20:24.478207 23020 master.cpp:1330] Agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0 at slave(449)@192.10.1.6:63810 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0702 08:20:24.478207 23020 master.cpp:3340] Disconnecting agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0 at slave(449)@192.10.1.6:63810 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0702 08:20:24.478207 23020 master.cpp:3359] Deactivating agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0 at slave(449)@192.10.1.6:63810 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0702 08:20:24.479210 4744 hierarchical.cpp:346] Removed framework 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-0000
I0702 08:20:24.479210 4744 hierarchical.cpp:769] Agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0 deactivated
I0702 08:20:24.479210 19464 containerizer.cpp:2407] Destroying container 84c78673-b984-460a-9a7b-e24668239a21 in RUNNING state
I0702 08:20:24.479210 19464 containerizer.cpp:3021] Transitioning the state of container 84c78673-b984-460a-9a7b-e24668239a21 from RUNNING to DESTROYING
I0702 08:20:24.480211 19464 launcher.cpp:155] Asked to destroy container 84c78673-b984-460a-9a7b-e24668239a21
I0702 08:20:24.559197 23020 containerizer.cpp:2860] Container 84c78673-b984-460a-9a7b-e24668239a21 has exited
I0702 08:20:24.587218 22780 master.cpp:1172] Master terminating
I0702 08:20:24.590195 15868 hierarchical.cpp:612] Removed agent 50a50bfd-8f71-4d8f-9cde-1ad2dae42570-S0
I0702 08:20:24.905164 4864 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On July 2, 2018, 6:03 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67798/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 6:03 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the "old" cli to the cmake build. We generate a binary
> `mesos` unless the new cli is built; in that case we create a binary
> `mesos-old`.
>
>
> Diffs
> -----
>
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
>
>
> Diff: https://reviews.apache.org/r/67798/diff/1/
>
>
> Testing
> -------
>
> * `cmake -GNinja .. && ninja && ./src/mesos`
> * `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67798: Added "old" cli to the cmake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205642
-----------------------------------------------------------
Did you pull this out of https://reviews.apache.org/r/67751/?
- Andrew Schwartzmeyer
On July 1, 2018, 11:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67798/
> -----------------------------------------------------------
>
> (Updated July 1, 2018, 11:03 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the "old" cli to the cmake build. We generate a binary
> `mesos` unless the new cli is built; in that case we create a binary
> `mesos-old`.
>
>
> Diffs
> -----
>
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
>
>
> Diff: https://reviews.apache.org/r/67798/diff/1/
>
>
> Testing
> -------
>
> * `cmake -GNinja .. && ninja && ./src/mesos`
> * `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67798: Added "old" cli to the cmake build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67798/#review205628
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67798]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 2, 2018, 6:03 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67798/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 6:03 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the "old" cli to the cmake build. We generate a binary
> `mesos` unless the new cli is built; in that case we create a binary
> `mesos-old`.
>
>
> Diffs
> -----
>
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
>
>
> Diff: https://reviews.apache.org/r/67798/diff/1/
>
>
> Testing
> -------
>
> * `cmake -GNinja .. && ninja && ./src/mesos`
> * `cmake -GNinja -DENABLE_NEW_CLI=ON .. && ninja && ./src/mesos; ./src/mesos-old`
>
>
> Thanks,
>
> Benjamin Bannier
>
>