You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ifilonenko <gi...@git.apache.org> on 2018/08/19 21:47:52 UTC

[GitHub] spark pull request #22145: [SPARK-25152][K8S] Enable SparkR Integration Test...

GitHub user ifilonenko opened a pull request:

    https://github.com/apache/spark/pull/22145

     [SPARK-25152][K8S] Enable SparkR Integration Tests for Kubernetes

    ## What changes were proposed in this pull request?
    
    Re-introduced SparkR integration tests as part of the SparkR on K8S release. This PR awaits Jenkins availability. 
    
    ## How was this patch tested?
    
    This patched was tested with unit tests and integration tests. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ifilonenko/spark spark-r-with-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22145
    
----
commit 510b806420b37ce067f80b1f85b84ae34714e91b
Author: Ilan Filonenko <if...@...>
Date:   2018-08-19T21:45:21Z

    reintroduced sparkr integration tests

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #94936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94936/testReport)** for PR 22145 at commit [`510b806`](https://github.com/apache/spark/commit/510b806420b37ce067f80b1f85b84ae34714e91b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    what's the latest on this, btw?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by mccheah <gi...@git.apache.org>.
Github user mccheah commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Just wanted to ping on this - how close are we to getting this working on CI?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #96642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96642/testReport)** for PR 22145 at commit [`30cf53f`](https://github.com/apache/spark/commit/30cf53f2ccc7988730d70f57d89ca8a4b1f4d00c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test status failure
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/2308/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test status failure
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3497/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2333/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by ifilonenko <gi...@git.apache.org>.
Github user ifilonenko commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    this PR is waiting on @shaneknapp to migrate to ubuntu and have R setup in the node responsible for distribution building. This was planning on being done right after the 2.4 cut. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #94936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94936/testReport)** for PR 22145 at commit [`510b806`](https://github.com/apache/spark/commit/510b806420b37ce067f80b1f85b84ae34714e91b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #94972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94972/testReport)** for PR 22145 at commit [`510b806`](https://github.com/apache/spark/commit/510b806420b37ce067f80b1f85b84ae34714e91b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test status failure
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/2333/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94972/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3497/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    test this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96642/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    @shaneknapp could we do this soon?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/2333/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #96642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96642/testReport)** for PR 22145 at commit [`30cf53f`](https://github.com/apache/spark/commit/30cf53f2ccc7988730d70f57d89ca8a4b1f4d00c).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    closer.  just started working again on the ubuntu port about a week ago.
    hopefully before EOY.
    
    On Thu, Nov 1, 2018 at 10:41 AM mccheah <no...@github.com> wrote:
    
    > Just wanted to ping on this - how close are we to getting this working on
    > CI?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/22145#issuecomment-435119399>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABiDrOTtfONuGh4jmTX5b_sOx7zSwKpzks5uqzJWgaJpZM4WDIaa>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    yes, hopefully soon.  i won't be able to start on this for at least another
    week due to our lab having a big event this coming week.
    
    On Sat, Oct 6, 2018 at 5:55 PM Felix Cheung <no...@github.com>
    wrote:
    
    > @shaneknapp <https://github.com/shaneknapp> could we do this soon?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/22145#issuecomment-427617039>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABiDrLNFewd2BvHoSWBI4X791ITbTu_Zks5uiVEegaJpZM4WDIaa>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/2308/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3497/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2308/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    interesting.  looks like this could be a 'thing' w/minikube.  i was able to use virsh and get the minikube-net network up w/o issue.  related, and quite recent thread here:
    https://github.com/kubernetes/minikube/issues/2513
    
    i'll spot check the other workers, but just as an FYI:  i'll be out all day, and unable to check back in until this evening.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by ifilonenko <gi...@git.apache.org>.
Github user ifilonenko commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    This PR should fail integration tests rn, until the Jenkins OS is updated, but error right now is in terms of the minikube environment: 
    `Error creating VM: virError(Code=55, Domain=19, Message='Requested operation is not valid: network 'minikube-net' is not active')`
    
    @shaneknapp take a look if you can


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94936/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    **[Test build #94972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94972/testReport)** for PR 22145 at commit [`510b806`](https://github.com/apache/spark/commit/510b806420b37ce067f80b1f85b84ae34714e91b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22145
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org