You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by etzelc <gi...@git.apache.org> on 2017/07/17 10:18:43 UTC
[GitHub] maven-integration-testing pull request #23: [MNG-6265] Integration test for ...
GitHub user etzelc opened a pull request:
https://github.com/apache/maven-integration-testing/pull/23
[MNG-6265] Integration test for Maven script can break if "-f" path contains special characters
Add the integration test for issue MNG-6256 (pull request apache/maven#128). https://issues.apache.org/jira/browse/MNG-6256
I set the version contraint to `"[3.5.1,)"`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/etzelc/maven-integration-testing MNG-6256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-integration-testing/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 5e8c834b63c2169c367cd4650694ab5083e74ea0
Author: Christoph Etzel <ch...@informatik.uni-augsburg.de>
Date: 2017-07-14T08:43:58Z
MNG-6265 Add integration test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...
Posted by etzelc <gi...@git.apache.org>.
Github user etzelc commented on the issue:
https://github.com/apache/maven-integration-testing/pull/23
Thanks for your testing effort. I am surprised both tests pass in your Windows environment with 3.5.0. I tested the IT with two different clients (Windows 7 and Windows 10) and while `folder-with- -space/pom.xml` passes, the `folder-with-)-closing-bracket/pom.xml` test fails.
The `folder-with- -space/pom.xml` test was developed to cover MNG-6177 (https://issues.apache.org/jira/browse/MNG-6177), which has no IT and was already targeting "special" characters like spaces and more.
I have implemented the IT in a way to perform a successful maven run, since this is what you usually expect from maven. The example `mvn -f "folderWithClosing)Bracket/pomFolder"` from issue MNG-6256 (https://issues.apache.org/jira/browse/MNG-6256) was chosen to have a very short example with no prerequisites. With 3.5.0 you should see the same error even if a well formed POM exist at the specified location and you set additionally a goal (see IT test `folder-with-)-closing-bracket/pom.xml`).
I did not implement a dedicated test for the error message, because it may change over the time and the purpose of my patch was not to have a correct error message (which is included in the patch implicitly), but have a successful maven run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...
Posted by Tunaki <gi...@git.apache.org>.
Github user Tunaki commented on the issue:
https://github.com/apache/maven-integration-testing/pull/23
I ran the IT with 3.5.0 on Windows, but it passed. Since the issue resolves around the error message that is printed on the console, I think the two files `folder-with- -space/pom.xml` and `folder-with-)-closing-bracket/pom.xml` should be removed, and instead it should be tested that the correct error message is printed, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org