You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/23 14:53:21 UTC
[GitHub] [solr] janhoy opened a new pull request #694: SOLR-16041 Prepare Smoketester to be able to run on local release folder in Jeknins
janhoy opened a new pull request #694:
URL: https://github.com/apache/solr/pull/694
https://issues.apache.org/jira/browse/SOLR-16041
* Allows smoketester to be run directly on `distribution/build/release/` folder in build
* Allow `.gitrev` file in that folder
* Make sure that `docker/` folder is produced (with Dockerfile.local) also for a non-signed release
* Be explicit about disabling signing in buildAndPushRelease.py if not `--gpg-key-id` is given
PS: This PR currently whitelists some javax jars, but that will be reverted once SOLR-16048 is merged #693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #694: SOLR-16041 Prepare Smoketester to be able to run on local release folder in Jeknins
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #694:
URL: https://github.com/apache/solr/pull/694#issuecomment-1049778822
I can factor out the removal of unused `distZip` into its own PR if folks prefer that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #694: SOLR-16041: Prepare Smoketester to be able to run on local release folder in Jenkins
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #694:
URL: https://github.com/apache/solr/pull/694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #694: SOLR-16041: Prepare Smoketester to be able to run on local release folder in Jenkins
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #694:
URL: https://github.com/apache/solr/pull/694#discussion_r814999183
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -115,7 +115,7 @@ def noJavaPackageClasses(desc, file):
with zipfile.ZipFile(file) as z2:
for name2 in z2.namelist():
if name2.endswith('.class') and (name2.startswith('java/') or name2.startswith('javax/')):
- raise RuntimeError('%s contains sheisty class "%s"' % (desc, name2))
+ raise RuntimeError('%s contains sheisty class "%s"' % (desc, name2))
Review comment:
```suggestion
raise RuntimeError('%s contains java or javax class "%s"' % (desc, name2))
```
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1104,9 +1106,14 @@ def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys,
print(' unshortened: %s' % newBaseURL)
baseURL = newBaseURL
- for text, subURL in getDirEntries(baseURL):
- if text.lower().find('solr') != -1:
- solrPath = subURL
+ if baseURL.endswith('distribution/build/release'):
+ # Used when buiding release locally in Jenkins
Review comment:
```suggestion
# Used when building release locally in Jenkins
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #694: SOLR-16041: Prepare Smoketester to be able to run on local release folder in Jenkins
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #694:
URL: https://github.com/apache/solr/pull/694#issuecomment-1057937807
> Question, when the release folder gets uploaded to svn, can we omit the Dockerfile.official at that point? It doesn't particularly matter I guess, but no real reason to include it in the official release. It's very nice to have it for the release candidates though
Good point. We already have some `svn delete` commands to remove maven folder prior to moving from svn staging to svn release, so perhaps we can do the same with the docker folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #694: SOLR-16041 Prepare Smoketester to be able to run on local release folder in Jeknins
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #694:
URL: https://github.com/apache/solr/pull/694#discussion_r813803073
##########
File path: solr/distribution/build.gradle
##########
@@ -59,11 +59,10 @@ configurations {
dependencies {
changesHtml project(path: ":solr:documentation", configuration: "changesHtml")
- docker project(path: ':solr:docker', configuration: project.ext.withSignedArtifacts ? 'packagingOfficial' : 'packaging')
+ docker project(path: ':solr:docker', configuration: project.ext.withSignedArtifacts ? 'packagingOfficial' : 'packagingLocal')
Review comment:
@HoustonPutman I added a new configuration `packagingLocal` since the existing `packaging` configuration did not produce the `docker/` output. This is kind of a quick fix, it may also be possible to change the `from(configurations.docker` below to pull out `Dockerfile.local` from the result of `packaging`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #694: SOLR-16041 Prepare Smoketester to be able to run on local release folder in Jeknins
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #694:
URL: https://github.com/apache/solr/pull/694#issuecomment-1050300152
> I can factor out the removal of unused `distZip` into its own PR if folks prefer that...
I moved the unrelated distZip to #703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #694: SOLR-16041: Prepare Smoketester to be able to run on local release folder in Jenkins
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #694:
URL: https://github.com/apache/solr/pull/694#discussion_r817935617
##########
File path: solr/distribution/build.gradle
##########
@@ -59,11 +59,10 @@ configurations {
dependencies {
changesHtml project(path: ":solr:documentation", configuration: "changesHtml")
- docker project(path: ':solr:docker', configuration: project.ext.withSignedArtifacts ? 'packagingOfficial' : 'packaging')
+ docker project(path: ':solr:docker', configuration: project.ext.withSignedArtifacts ? 'packagingOfficial' : 'packagingLocal')
Review comment:
Ahhh I understand why this broke now, because we renamed `Dockerfile.local` to `Dockerfile` in the binary release. This looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org