You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2022/06/12 22:55:43 UTC
[iceberg] branch master updated: Core: Rename JDBC namespace property column to non-keyword (#5017)
This is an automated email from the ASF dual-hosted git repository.
blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new c4cb017f0 Core: Rename JDBC namespace property column to non-keyword (#5017)
c4cb017f0 is described below
commit c4cb017f0225464d77aa80a56c67e5425f3e6f4d
Author: Sung Yun <10...@users.noreply.github.com>
AuthorDate: Sun Jun 12 18:55:39 2022 -0400
Core: Rename JDBC namespace property column to non-keyword (#5017)
---
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java b/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
index 39906e3c2..395e38bc6 100644
--- a/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
+++ b/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
@@ -80,8 +80,8 @@ final class JdbcUtil {
// Catalog Namespace Properties
static final String NAMESPACE_PROPERTIES_TABLE_NAME = "iceberg_namespace_properties";
static final String NAMESPACE_NAME = "namespace";
- static final String NAMESPACE_PROPERTY_KEY = "key";
- static final String NAMESPACE_PROPERTY_VALUE = "value";
+ static final String NAMESPACE_PROPERTY_KEY = "property_key";
+ static final String NAMESPACE_PROPERTY_VALUE = "property_value";
static final String CREATE_NAMESPACE_PROPERTIES_TABLE =
"CREATE TABLE " + NAMESPACE_PROPERTIES_TABLE_NAME +
@@ -149,7 +149,7 @@ final class JdbcUtil {
StringBuilder sqlStatement = new StringBuilder("UPDATE " + NAMESPACE_PROPERTIES_TABLE_NAME +
" SET " + NAMESPACE_PROPERTY_VALUE + " = CASE");
for (int i = 0; i < size; i += 1) {
- sqlStatement.append(" WHEN key = ? THEN ?");
+ sqlStatement.append(" WHEN " + NAMESPACE_PROPERTY_KEY + " = ? THEN ?");
}
sqlStatement.append(" END WHERE " + CATALOG_NAME + " = ? AND " +
NAMESPACE_NAME + " = ? AND " + NAMESPACE_PROPERTY_KEY + " IN ");