You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/14 01:07:33 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI
HyukjinKwon commented on a change in pull request #32436:
URL: https://github.com/apache/spark/pull/32436#discussion_r632197610
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
##########
@@ -31,6 +31,14 @@ function getThreadDumpEnabled() {
return threadDumpEnabled;
}
+function formatLossReason(removeReason, type, row) {
Review comment:
Eh, uhoh. Seems like the JavaScript linter is broken by this:
```
added 118 packages in 1.482s
/__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
34:41 error 'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars
34:47 error 'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars
35:1 error Expected indentation of 2 spaces but found 4 indent
36:1 error Expected indentation of 4 spaces but found 7 indent
37:1 error Expected indentation of 2 spaces but found 4 indent
38:1 error Expected indentation of 4 spaces but found 7 indent
39:1 error Expected indentation of 2 spaces but found 4 indent
556:1 error Expected indentation of 14 spaces but found 16 indent
557:1 error Expected indentation of 14 spaces but found 16 indent
```
Mind taking a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org