You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ni...@apache.org on 2019/05/14 03:35:05 UTC
[kylin] branch master updated: Add unit tests (#639)
This is an automated email from the ASF dual-hosted git repository.
nic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/master by this push:
new 20fa8b1 Add unit tests (#639)
20fa8b1 is described below
commit 20fa8b1530e0d09f4393242db282dff43b930b00
Author: Michael Hausegger <ha...@googlemail.com>
AuthorDate: Tue May 14 05:34:59 2019 +0200
Add unit tests (#639)
* Add tests for DefaultX509TrustManager
* Added tests for HadoopCmdOutput
---
.../mr/common/DefaultX509TrustManagerTest.java | 50 +++++++++++++++++++++
.../engine/mr/common/HadoopCmdOutputTest.java | 52 ++++++++++++++++++++++
2 files changed, 102 insertions(+)
diff --git a/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/DefaultX509TrustManagerTest.java b/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/DefaultX509TrustManagerTest.java
new file mode 100644
index 0000000..9a113db
--- /dev/null
+++ b/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/DefaultX509TrustManagerTest.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.engine.mr.common;
+
+import org.junit.Test;
+
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.cert.X509Certificate;
+
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Unit tests for class {@link DefaultX509TrustManager}.
+ *
+ * @see DefaultX509TrustManager
+ *
+ */
+public class DefaultX509TrustManagerTest{
+
+ @Test(expected = NullPointerException.class)
+ public void testIsServerTrustedThrowsNullPointerException() throws KeyStoreException, NoSuchAlgorithmException {
+ DefaultX509TrustManager defaultX509TrustManager = new DefaultX509TrustManager(null);
+
+ defaultX509TrustManager.isServerTrusted(new X509Certificate[1]);
+ }
+
+ @Test
+ public void testIsServerTrustedWithNull() throws KeyStoreException, NoSuchAlgorithmException {
+ DefaultX509TrustManager defaultX509TrustManager = new DefaultX509TrustManager(null);
+
+ assertTrue(defaultX509TrustManager.isServerTrusted(null));
+ }
+
+}
\ No newline at end of file
diff --git a/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/HadoopCmdOutputTest.java b/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/HadoopCmdOutputTest.java
new file mode 100644
index 0000000..6d8cbc6
--- /dev/null
+++ b/engine-mr/src/test/java/org/apache/kylin/engine/mr/common/HadoopCmdOutputTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.engine.mr.common;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.mapreduce.Job;
+import org.junit.Test;
+
+import java.io.IOException;
+
+import static org.junit.Assert.assertNull;
+
+/**
+ * Unit tests for class {@link HadoopCmdOutput}.
+ *
+ * @see HadoopCmdOutput
+ *
+ */
+public class HadoopCmdOutputTest{
+
+ @Test(expected = IllegalStateException.class)
+ public void testGetMrJobIdThrowsIllegalStateException() throws IOException {
+ Job job = Job.getInstance(new Configuration(false));
+ HadoopCmdOutput hadoopCmdOutput = new HadoopCmdOutput(job, new StringBuilder());
+
+ assertNull(hadoopCmdOutput.getMrJobId());
+ }
+
+ @Test
+ public void testUpdateJobCounterCatchesEveryInternalException() throws IOException {
+ Job job = Job.getInstance(new Configuration(false));
+ HadoopCmdOutput hadoopCmdOutput = new HadoopCmdOutput(job, new StringBuilder());
+
+ hadoopCmdOutput.updateJobCounter();
+ }
+
+}
\ No newline at end of file