[GitHub] [skywalking] lt964709769 commented on issue #3004: Improve RegisterPersistentWorker by bulk persistence to reduce cluster blocking

[GitBox <gi...@apache.org>]

lt964709769 commented on issue #3004: Improve RegisterPersistentWorker by bulk persistence to reduce cluster blocking
URL: https://github.com/apache/skywalking/pull/3004#issuecomment-508386945
 
 
   > Could you indicate what is the difference between your LRU and existing Map.
   > Such as following, this should have guaranteed there is no duplicated.
   > 
   > ```java
   >     private void onWork(RegisterSource registerSource) {
   >         if (!sources.containsKey(registerSource)) {
   >             sources.put(registerSource, registerSource);
   >         } else {
   >             sources.get(registerSource).combine(registerSource);
   >         }
   > ```
   
   This Map is used to combine the registration information of this batch. 
   In this improvement, LRU can be access across batches. It is used to cache the registration information to reduce access to data sources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services