You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "arkady borkovsky (JIRA)" <ji...@apache.org> on 2007/04/05 02:43:32 UTC

[jira] Created: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

hdfs -rm should NOT fail if one of the files to remove is missing
-----------------------------------------------------------------

                 Key: HADOOP-1207
                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
             Project: Hadoop
          Issue Type: Bug
            Reporter: arkady borkovsky
            Priority: Minor


It looks like hdfs -rm with wild card argument first builds the list of
files to delete, and then deletes them one by one.
(This is OK so far).

If one of the files on the list gets deleted by someone else before the
command reaches it, the command fails.
This seems a wrong behavior to me. I'd expect the command report the problem
and continue deleting the rest of the files.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1207:
-------------------------------------------

    Status: Patch Available  (was: Open)

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1207:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.14.0
         Assignee: Tsz Wo (Nicholas), SZE
           Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Tsz Wo!

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1207:
-------------------------------------------

    Attachment: HADOOP-1207_20070614.patch

added a class DelayedExceptionThrowing for handling IOExceptions for the commands rm and cat

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>         Attachments: HADOOP-1207_20070614.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505351 ] 

Hadoop QA commented on HADOOP-1207:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12359904/HADOOP-1207_20070615.patch applied and successfully tested against trunk revision r547649.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/290/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/290/console

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506037 ] 

Hadoop QA commented on HADOOP-1207:
-----------------------------------

Integrated in Hadoop-Nightly #127 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/127/])

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1207:
-------------------------------------------

    Attachment:     (was: HADOOP-1207_20070614.patch)

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-1207:
-------------------------------------

    Component/s: dfs

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505342 ] 

dhruba borthakur commented on HADOOP-1207:
------------------------------------------

+1 code looks good.

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1207) hdfs -rm should NOT fail if one of the files to remove is missing

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1207:
-------------------------------------------

    Attachment: HADOOP-1207_20070615.patch

Added a private class DelayedExceptionThrowing.

> hdfs -rm should NOT fail if one of the files to remove is missing
> -----------------------------------------------------------------
>
>                 Key: HADOOP-1207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1207
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: arkady borkovsky
>            Priority: Minor
>         Attachments: HADOOP-1207_20070615.patch
>
>
> It looks like hdfs -rm with wild card argument first builds the list of
> files to delete, and then deletes them one by one.
> (This is OK so far).
> If one of the files on the list gets deleted by someone else before the
> command reaches it, the command fails.
> This seems a wrong behavior to me. I'd expect the command report the problem
> and continue deleting the rest of the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.