You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/13 03:43:15 UTC
[GitHub] [echarts] AmosChenYQ opened a new pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
AmosChenYQ opened a new pull request #15337:
URL: https://github.com/apache/echarts/pull/15337
…vel above detail and title
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Add a 'showAbove' style to pointer of gauge chart to control whether pointer shows above detail and title item.
### Fixed issues
<!--
- #xxxx: ...
-->
- https://github.com/apache/echarts/issues/15195
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
After https://github.com/apache/echarts/pull/15326, default z-level is default under detail and title item and can not change. During cases like car speed dashboard, pointer needs to be above speed number instead of above it.
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
Add a 'showAbove' style to pointer of gauge chart to control whether pointer shows above detail and title item.
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] AmosChenYQ commented on pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
AmosChenYQ commented on pull request #15337:
URL: https://github.com/apache/echarts/pull/15337#issuecomment-879128309
> @AmosChenYQ Please also add documentation in [echarts-doc](https://github.com/apache/echarts-doc), since `showAbove ` is a new feature
https://github.com/apache/echarts-doc/pull/189 plz review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15337:
URL: https://github.com/apache/echarts/pull/15337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15337:
URL: https://github.com/apache/echarts/pull/15337#issuecomment-878753737
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15337:
URL: https://github.com/apache/echarts/pull/15337#issuecomment-878757240
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #15337:
URL: https://github.com/apache/echarts/pull/15337#issuecomment-878757179
Indeed it will be more flexible to be configurable. Nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #15337: enable pointer's z-level adjustment in gauge chart & set default z-le…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #15337:
URL: https://github.com/apache/echarts/pull/15337#issuecomment-878764822
@AmosChenYQ Please also add documentation in [echarts-doc](https://github.com/apache/echarts-doc), since `showAbove ` is a new feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org