You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/19 00:59:00 UTC

[jira] [Commented] (CALCITE-2219) Avatica Connection/Statement/ResultSet don't throw if resource is closed

    [ https://issues.apache.org/jira/browse/CALCITE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404266#comment-16404266 ] 

ASF GitHub Bot commented on CALCITE-2219:
-----------------------------------------

GitHub user laurentgo opened a pull request:

    https://github.com/apache/calcite-avatica/pull/33

    [CALCITE-2219] Check if resource is closed, and throws

    According to JDBC spec, most methods from Connection, Statement,
    PreparedStatement and ResultSet should throw an exception if the
    resource is closed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/calcite-avatica laurentgo/CALCITE-2219

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/calcite-avatica/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit a2ac579f46ce9c8eb0bf80373f010b45821df662
Author: Laurent Goujon <la...@...>
Date:   2018-03-18T23:52:51Z

    Fix static field access warnings
    
    Fix warnings about accessing AvaticaConnection.HELPER static field by
    using a class instance.

commit 9e9248474aa88bc1c82a5a57629628838e0fb980
Author: Laurent Goujon <la...@...>
Date:   2018-03-18T23:46:30Z

    [CALCITE-2219] Check if resource is closed, and throws
    
    According to JDBC spec, most methods from Connection, Statement,
    PreparedStatement and ResultSet should throw an exception if the
    resource is closed.

----


> Avatica Connection/Statement/ResultSet don't throw if resource is closed
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-2219
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2219
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Major
>
> According to JDBC spec/Javadoc, almost all methods of {{Connection}}/{{Statement}}/{{PreparedStatement}}/{{ResultSet}} should throw an exception if resource is closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)