You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/21 18:01:02 UTC

[GitHub] [camel] mrinalsharma commented on pull request #8749: Fixed Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml

mrinalsharma commented on PR #8749:
URL: https://github.com/apache/camel/pull/8749#issuecomment-1322449756

   In the method getDependencies(), we are trying to read `property camel.jbang.dependencies`. If its null then the method should return empty string.
   
   Run.java:
   if getDependencies() doesn't return blank then merge the dependencies read from file and the dependencies passes as --deps parameter.
   
   ExportQuarkus.java
   `camel-quarkus-core,camel-quarkus-platform-http,camel-quarkus-microprofile-health` are  already defined in `quarkus-pom.tmpl'` so there is no need to define them again. Adding again in pom.xml cause a compilation error.
   
   ExportBaseCommand.jaja
   The change avoids adding a blank dependency in pom.xml. Blank dependency causes a compilation error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org