You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/28 08:18:58 UTC
[GitHub] [rocketmq] wyf224 opened a new pull request #2524: [ISSUE #2523]support pushConsumer get serviceState
wyf224 opened a new pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524
**Make sure set the target branch to `develop`**
## What is the purpose of the change
#2523
## Brief changelog
1.In DefaultMQPushConsumerImpl,change makeSureStateOK from private to public.
2.In DefaultMQPushConsumer, add a method makeSureStateOK.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751635011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=h1) Report
> Merging [#2524](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=desc) (0239421) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2524 +/- ##
==========================================
Coverage 45.97% 45.97%
Complexity 4318 4318
==========================================
Files 547 547
Lines 36236 36236
Branches 4808 4808
==========================================
Hits 16658 16658
Misses 17491 17491
Partials 2087 2087
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=footer). Last update [0239421...a011bea](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751634959
[](https://coveralls.io/builds/35966075)
Coverage decreased (-0.07%) to 51.872% when pulling **18698d29eaa544114ad8c4719e7aa6d4ac280285 on wyf224:feature-consumer** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751635011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=h1) Report
> Merging [#2524](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=desc) (18698d2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2524 +/- ##
=============================================
- Coverage 45.95% 45.91% -0.04%
+ Complexity 4316 4314 -2
=============================================
Files 547 547
Lines 36236 36238 +2
Branches 4808 4808
=============================================
- Hits 16651 16640 -11
- Misses 17497 17512 +15
+ Partials 2088 2086 -2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `54.00% <0.00%> (-0.55%)` | `46.00 <0.00> (ø)` | |
| [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `8.86% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-5.41%)` | `3.00% <0.00%> (ø%)` | |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-4.45%)` | `8.00% <0.00%> (-1.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `58.60% <0.00%> (-3.26%)` | `31.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | `25.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `48.97% <0.00%> (-0.44%)` | `89.00% <0.00%> (ø%)` | |
| [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.60% <0.00%> (-0.32%)` | `3.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=footer). Last update [0239421...18698d2](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2524: [ISSUE #2523]support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751634959
[](https://coveralls.io/builds/35964420)
Coverage decreased (-0.1%) to 51.795% when pulling **3a6831b15611a33337a64cbf127a90324cdf9b8e on wyf224:feature-consumer** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751635011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=h1) Report
> Merging [#2524](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=desc) (a011bea) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **increase** coverage by `2.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2524 +/- ##
=============================================
+ Coverage 45.95% 48.41% +2.46%
+ Complexity 4316 3173 -1143
=============================================
Files 547 418 -129
Lines 36236 26355 -9881
Branches 4808 3500 -1308
=============================================
- Hits 16651 12760 -3891
+ Misses 17497 11945 -5552
+ Partials 2088 1650 -438
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | `13.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | `25.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
| [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.60% <0.00%> (-0.32%)` | `3.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `66.42% <0.00%> (-0.11%)` | `79.00% <0.00%> (ø%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | `30.00% <0.00%> (ø%)` | |
| [...ocketmq/client/impl/producer/TopicPublishInfo.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9Ub3BpY1B1Ymxpc2hJbmZvLmphdmE=) | | | |
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | | | |
| [...apache/rocketmq/client/trace/TraceDataEncoder.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VEYXRhRW5jb2Rlci5qYXZh) | | | |
| [.../client/consumer/store/OffsetSerializeWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvT2Zmc2V0U2VyaWFsaXplV3JhcHBlci5qYXZh) | | | |
| ... and [130 more](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=footer). Last update [0239421...a011bea](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751635011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=h1) Report
> Merging [#2524](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=desc) (24ae31b) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2524 +/- ##
=============================================
- Coverage 45.95% 45.92% -0.03%
Complexity 4316 4316
=============================================
Files 547 547
Lines 36236 36237 +1
Branches 4808 4808
=============================================
- Hits 16651 16642 -9
- Misses 17497 17506 +9
- Partials 2088 2089 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `54.77% <100.00%> (+0.22%)` | `47.00 <1.00> (+1.00)` | |
| [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | `13.00% <0.00%> (-1.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `59.06% <0.00%> (-2.80%)` | `32.00% <0.00%> (ø%)` | |
| [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | `25.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `58.11% <0.00%> (-1.71%)` | `29.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
| [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.60% <0.00%> (-0.32%)` | `3.00% <0.00%> (ø%)` | |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `49.70% <0.00%> (+0.29%)` | `90.00% <0.00%> (+1.00%)` | |
| [...ava/org/apache/rocketmq/store/ha/HAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBQ29ubmVjdGlvbi5qYXZh) | `75.00% <0.00%> (+0.46%)` | `5.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=footer). Last update [0239421...24ae31b](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751634959
[](https://coveralls.io/builds/35966653)
Coverage decreased (-0.2%) to 51.787% when pulling **24ae31b64b329320e23a1c51e285dcc76cc8a464 on wyf224:feature-consumer** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2524: [ISSUE #2523]support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751635011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=h1) Report
> Merging [#2524](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=desc) (3a6831b) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **increase** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2524 +/- ##
=============================================
+ Coverage 45.95% 46.01% +0.06%
- Complexity 4316 4320 +4
=============================================
Files 547 547
Lines 36236 36238 +2
Branches 4808 4808
=============================================
+ Hits 16651 16675 +24
+ Misses 17497 17470 -27
- Partials 2088 2093 +5
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `54.00% <0.00%> (-0.55%)` | `46.00 <0.00> (ø)` | |
| [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `8.86% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `58.60% <0.00%> (-3.26%)` | `31.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `58.11% <0.00%> (-1.71%)` | `29.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `42.96% <0.00%> (+0.36%)` | `19.00% <0.00%> (+3.00%)` | |
| [...ava/org/apache/rocketmq/store/ha/HAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBQ29ubmVjdGlvbi5qYXZh) | `75.00% <0.00%> (+0.46%)` | `5.00% <0.00%> (ø%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (+0.65%)` | `26.00% <0.00%> (+1.00%)` | |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `50.14% <0.00%> (+0.73%)` | `90.00% <0.00%> (+1.00%)` | |
| [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `54.58% <0.00%> (+7.96%)` | `35.00% <0.00%> (+2.00%)` | |
| ... and [1 more](https://codecov.io/gh/apache/rocketmq/pull/2524/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=footer). Last update [0239421...3a6831b](https://codecov.io/gh/apache/rocketmq/pull/2524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2524: [ISSUE #2523] Support pushConsumer get serviceState
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2524:
URL: https://github.com/apache/rocketmq/pull/2524#issuecomment-751634959
[](https://coveralls.io/builds/35967795)
Coverage decreased (-0.05%) to 51.885% when pulling **a011bea3ff545da37b3019a0a4c25a49725f5336 on wyf224:feature-consumer** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org