You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/06/20 19:55:01 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41678: [SPARK-44110][BUILD] Propagate proxy settings to forked JVMs

dongjoon-hyun commented on code in PR #41678:
URL: https://github.com/apache/spark/pull/41678#discussion_r1235761038


##########
project/SparkBuild.scala:
##########
@@ -342,6 +342,18 @@ object SparkBuild extends PomBuild {
       }
     },
 
+    // Copy system properties to forked JVMs so that tests know proxy settings

Review Comment:
   Did you try to use `SBT_OPTS` instead of this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org