[GitHub] [beam] AnandInguva commented on a diff in pull request #22462: Upgrades pip before installing Beam for Python default expansion service

[GitBox <gi...@apache.org>]

AnandInguva commented on code in PR #22462:
URL: https://github.com/apache/beam/pull/22462#discussion_r931147753


##########
sdks/java/extensions/python/src/main/resources/org/apache/beam/sdk/extensions/python/bootstrap_beam_venv.py:
##########
@@ -92,6 +92,13 @@ def maybe_strict_version(s):
     if not os.path.exists(venv_python):
         try:
             subprocess.run([executable, '-m', 'venv', venv_dir], check=True)
+
+            # Beam recommends upgrading pip before installing.
+            subprocess.run([
+                venv_python, '-m', 'pip', 'install', '--upgrade', 'pip'

Review Comment:
   Maybe upgrade setuptools with pip as well. Some images use very old setuptools



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org