[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #18746: [fix](editLog) add sufficient replay logic and edit log for altering light schema change

["TangSiyang2001 (via GitHub)" <gi...@apache.org>]

TangSiyang2001 commented on code in PR #18746:
URL: https://github.com/apache/doris/pull/18746#discussion_r1168585582


##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterLSCHelper.java:
##########
@@ -79,7 +80,16 @@ public void enableLightSchemaChange() throws DdlException {
         final Map<Long, PFetchColIdsRequest> params = initParams();
         final PFetchColIdsResponse response = callForColumnIds(params);
         updateTableMeta(response);
-        modifyTableProperty();
+        writeEditLog(response);

Review Comment:
   I think we could keep `writeEditLog()` here so that we can omit the writeEditLog related logic in replay process, and just use `updateTableMeta()` then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org