You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/12 23:22:00 UTC

[jira] [Commented] (KNOX-2233) DefaultKeystoreService getCredentialForCluster uses cache without synchronization

    [ https://issues.apache.org/jira/browse/KNOX-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035781#comment-17035781 ] 

ASF subversion and git services commented on KNOX-2233:
-------------------------------------------------------

Commit 186ca4ac117c079aa96db91eb353080d6cea3740 in knox's branch refs/heads/master from Philip Zampino
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=186ca4a ]

KNOX-2233 - DefaultKeystoreService getCredentialForCluster uses cache without synchronization (#264)



> DefaultKeystoreService getCredentialForCluster uses cache without synchronization
> ---------------------------------------------------------------------------------
>
>                 Key: KNOX-2233
>                 URL: https://issues.apache.org/jira/browse/KNOX-2233
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.4.0
>            Reporter: Philip Zampino
>            Assignee: Philip Zampino
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The getCredentialForCluster(String, String) method of DefaultKeystoreService invokes checkCache(String, String) and addToCache(String, String) without any synchronization, despite the comments on those methods indicating that they are only called within critical sections of other methods. This method should be synchronized similar to what is done for the addCredentialForCluster(String, String, String) and removeCredentialForCluster(String, String) method implementations therein.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)