You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "rthomas320 (via GitHub)" <gi...@apache.org> on 2023/04/11 15:52:22 UTC
[GitHub] [daffodil-vscode] rthomas320 opened a new pull request, #580: - Provides the ability to re-select values of attributes items
rthomas320 opened a new pull request, #580:
URL: https://github.com/apache/daffodil-vscode/pull/580
- add logic to mitigate missing dfdl prefixes
- tweak logic to determine if cursor is between quotes
- Fixes incorrect velues triggered by nested elements
- fixes the resulting choice when intellisense is trigger between
two closing tags on a multi tag line
- fix wrong suggestions at end of schema open tag
- fix incorrect suggestion at beginning and end of a multi tag line
- fix broken attribute suggestions from inside multiline tag
- fixed cursor between alert open and close tags was returning
results for appinfo
- Change logic to for assert and discriminator auto complete
Closes #573
Closes #577
Closes #578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #580: Provides the ability to re-select values of attributes items
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] rthomas320 commented on pull request #580: Provides the ability to re-select values of attributes items
Posted by "rthomas320 (via GitHub)" <gi...@apache.org>.
rthomas320 commented on PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#issuecomment-1503808665
I added additional whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #580: Provides the ability to re-select values of attributes items
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#issuecomment-1503755518
@rt320 Can you please add some whitespace to the code. A lot of the code is to tightly together so adding some whitespaces would be helpful for reading. A lot of time before any `if`, `while`, `for` there should be a empty line before it unless nested for example
```ts
for () {
if () {
}
}
```
is fine but
```ts
for () {
if () {
}
if() {
}
}
```
should be
```ts
for () {
if () {
}
if() {
}
}
```
When you also change what is being done there should be an empty line. So if you go from making a bunch of variables to a `while` loop there should be a break in between
eg:
this:
```ts
const var1 = 0
const var2 = 0
const var3 = 0
const var4 = 0
const var5 = 0
while() {
}
````
should be
```ts
const var1 = 0
const var2 = 0
const var3 = 0
const var4 = 0
const var5 = 0
while() {
}
````
These are just minor formatting things that I think make the code easier to read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] rthomas320 commented on a diff in pull request #580: Provides the ability to re-select values of attributes items
Posted by "rthomas320 (via GitHub)" <gi...@apache.org>.
rthomas320 commented on code in PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#discussion_r1163942302
##########
src/language/providers/intellisense/attributeValueItems.ts:
##########
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// prettier-ignore
Review Comment:
Initially the file started out as a copy of attributeItems.ts. But the suggestions first offered a popup of the attribute name, once the attribute name was selected, then the choice values were given. I found that by using a 'switch" statement I was able to supply the attribute choices directly without the user having to select the attribute name first. When I made the change I forgot the prettier-ignore directive was in the file. I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #580: Provides the ability to re-select values of attributes items
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#discussion_r1163352751
##########
src/language/providers/intellisense/attributeValueItems.ts:
##########
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// prettier-ignore
Review Comment:
What needs ignoring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org