[GitHub] [ozone] smengcl commented on a change in pull request #2788: HDDS-5529. For any IOexception from @Replicated method we should throw it

[GitBox <gi...@apache.org>]

smengcl commented on a change in pull request #2788:
URL: https://github.com/apache/ozone/pull/2788#discussion_r794648318



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerImpl.java
##########
@@ -276,8 +274,7 @@ public void updatePipelineState(
           + " may have been deleted already.", pipelineID);
     } catch (IOException ex) {
       LOG.warn("Pipeline {} state update failed", pipelineID);

Review comment:
       nit: change the corresponding log level to error now that we are throwing in this case?
   
   ```suggestion
         LOG.error("Pipeline {} state update failed", pipelineID);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org