[GitHub] [druid] kfaraz commented on a diff in pull request #14235: Refactor: Add OverlordDuty to replace OverlordHelper and align with CoordinatorDuty

["kfaraz (via GitHub)" <gi...@apache.org>]

kfaraz commented on code in PR #14235:
URL: https://github.com/apache/druid/pull/14235#discussion_r1192091328


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/DurableStorageCleaner.java:
##########
@@ -75,66 +72,58 @@ public boolean isEnabled()
   }
 
   @Override
-  public void schedule(ScheduledExecutorService exec)
+  public void run()
   {
-    LOG.info("Starting the DurableStorageCleaner with the config [%s]", config);
+    try {

Review Comment:
   Thanks for pointing this out! You are right, neither of the existing duty/helpers are doing anything special with the exception, just logging it or wrapping it up and rethrowing it. I will get rid of these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org