[GitHub] [superset] eschutho commented on a diff in pull request #23174: feat: database extension registry

["eschutho (via GitHub)" <gi...@apache.org>]

eschutho commented on code in PR #23174:
URL: https://github.com/apache/superset/pull/23174#discussion_r1140839425


##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx:
##########
@@ -437,6 +458,33 @@ const ExtraOptions = ({
           </StyledInputContainer>
         )}
       </Collapse.Panel>
+      {dbConfigExtensions?.map?.(extension => {
+        const Extension =
+          extension.component as FunctionComponent<IExtensionProps>;
+        return (
+          <Collapse.Panel
+            header={
+              <div>
+                {extension.logo ? (
+                  <img
+                    alt="dbt Cloud"

Review Comment:
   is this alt meant to be hard coded?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org