You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/10/11 21:53:04 UTC
Review Request 52750: GEODE-1985: Check for index expression
reevalaution using a time window
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/
-----------------------------------------------------------
Review request for geode, Jason Huynh and nabarun nag.
Repository: geode
Description
-------
Changing the logic for how to we check to see if an entry may have been
concurrently modified while an indexed query is in progress.
The new logic just has a time window, defaulting to 10 minutes. If the
entry was changed less than 10 minutes for the query started, we will
reevaluate the index expression to make sure the entry is still valid.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 8ef82f1bee9831fa50a93f87bb9ed0b644a542b4
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 84ba926ee35638c4263a0d93a8be3fef1e2c5f7f
geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 46ccd47e96e75a8c4c6f3075b65a2d2447043213
geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java c7633ea05b0f8a90baf0c8f9e9849480421ebd45
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java 7cc2c12f80ba4248edca9035bbdfd839d20f70ad
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java 1160d4bdb755e39a2a5c52fb167b86e760e0ae88
Diff: https://reviews.apache.org/r/52750/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 52750: GEODE-1985: Check for index expression
reevalaution using a time window
Posted by Dan Smith <ds...@pivotal.io>.
> On Oct. 11, 2016, 10:11 p.m., Jason Huynh wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java, line 371
> > <https://reviews.apache.org/r/52750/diff/1/?file=1531244#file1531244line371>
> >
> > Was this intended for this diff?
Ah, that was supposed to be a separate change. Thanks!
> On Oct. 11, 2016, 10:11 p.m., Jason Huynh wrote:
> > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java, line 173
> > <https://reviews.apache.org/r/52750/diff/1/?file=1531243#file1531243line173>
> >
> > Would you be able to remove/modify this comment a bit? Mostly remove the bug number as it's not a geode number any more
Sure, I'll update that.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/#review152219
-----------------------------------------------------------
On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52750/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2016, 9:53 p.m.)
>
>
> Review request for geode, Jason Huynh and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Changing the logic for how to we check to see if an entry may have been
> concurrently modified while an indexed query is in progress.
>
> The new logic just has a time window, defaulting to 10 minutes. If the
> entry was changed less than 10 minutes for the query started, we will
> reevaluate the index expression to make sure the entry is still valid.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 8ef82f1bee9831fa50a93f87bb9ed0b644a542b4
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 84ba926ee35638c4263a0d93a8be3fef1e2c5f7f
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 46ccd47e96e75a8c4c6f3075b65a2d2447043213
> geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java c7633ea05b0f8a90baf0c8f9e9849480421ebd45
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java 7cc2c12f80ba4248edca9035bbdfd839d20f70ad
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java 1160d4bdb755e39a2a5c52fb167b86e760e0ae88
>
> Diff: https://reviews.apache.org/r/52750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 52750: GEODE-1985: Check for index expression
reevalaution using a time window
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52750/#review152219
-----------------------------------------------------------
Fix it, then Ship it!
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java (line 145)
<https://reviews.apache.org/r/52750/#comment221082>
Would you be able to remove/modify this comment a bit? Mostly remove the bug number as it's not a geode number any more
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java (line 371)
<https://reviews.apache.org/r/52750/#comment221083>
Was this intended for this diff?
- Jason Huynh
On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52750/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2016, 9:53 p.m.)
>
>
> Review request for geode, Jason Huynh and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Changing the logic for how to we check to see if an entry may have been
> concurrently modified while an indexed query is in progress.
>
> The new logic just has a time window, defaulting to 10 minutes. If the
> entry was changed less than 10 minutes for the query started, we will
> reevaluate the index expression to make sure the entry is still valid.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 8ef82f1bee9831fa50a93f87bb9ed0b644a542b4
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 84ba926ee35638c4263a0d93a8be3fef1e2c5f7f
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 46ccd47e96e75a8c4c6f3075b65a2d2447043213
> geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java c7633ea05b0f8a90baf0c8f9e9849480421ebd45
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AbstractIndexMaintenanceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexMaintenanceNoReevaluationIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/RangeIndexAPIJUnitTest.java 7cc2c12f80ba4248edca9035bbdfd839d20f70ad
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java 1160d4bdb755e39a2a5c52fb167b86e760e0ae88
>
> Diff: https://reviews.apache.org/r/52750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>