[GitHub] [hadoop] pjfanning commented on a diff in pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#discussion_r1300238501


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java:
##########
@@ -30,30 +30,35 @@
 import org.apache.hadoop.thirdparty.protobuf.ServiceException;
 
 /**
- * Helper methods for protobuf related RPC implementation
+ * Helper methods for protobuf related RPC implementation.
+ * This is deprecated because it references protobuf 2.5 classes
+ * as well as the shaded one -and may need an unshaded protobuf
+ * JAR on the classpath during complicated.

Review Comment:
   during compilation - instead complicated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org