You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/23 03:31:32 UTC
[Bug 120668] New: SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
https://issues.apache.org/ooo/show_bug.cgi?id=120668
Priority: P3
Bug ID: 120668
Assignee: ooo-issues@incubator.apache.org
Summary: SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Severity: normal
Issue Type: DEFECT
Classification: Code
OS: All
Reporter: zhangjf@apache.org
Hardware: All
Status: CONFIRMED
Version: AOO 3.4.0
Component: code
Product: performance
In api
void SdrModel::ImpCreateTables()
{
// der Writer hat seinen eigenen ColorTable
if (!bExtColorTable) pColorTable=new
XColorTable(aTablePath,(XOutdevItemPool*)pItemPool);
pDashList =new XDashList (aTablePath,(XOutdevItemPool*)pItemPool);
pLineEndList =new XLineEndList (aTablePath,(XOutdevItemPool*)pItemPool);
pHatchList =new XHatchList (aTablePath,(XOutdevItemPool*)pItemPool);
pGradientList=new XGradientList(aTablePath,(XOutdevItemPool*)pItemPool);
pBitmapList =new XBitmapList (aTablePath,(XOutdevItemPool*)pItemPool);
}
Next time, when calling SdrModel::Setxxx(), for ex,
void SetColorTable(XColorTable* pTable) { pColorTable=pTable;
}
The object is overwritten without free.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|ooo-issues@incubator.apache |zhangjf@apache.org
|.org |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79073|review? |
Flags| |
--- Comment #2 from zhang jianfang <zh...@apache.org> ---
Comment on attachment 79073
--> https://issues.apache.org/ooo/attachment.cgi?id=79073
fix code patch
Sorry, the patch still has problem, need more study.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79073| |review?
Flags| |
--- Comment #1 from zhang jianfang <zh...@apache.org> ---
Created attachment 79073
--> https://issues.apache.org/ooo/attachment.cgi?id=79073&action=edit
fix code patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79074|review? |
Flags| |
--- Comment #4 from zhang jianfang <zh...@apache.org> ---
Comment on attachment 79074
--> https://issues.apache.org/ooo/attachment.cgi?id=79074
refix code patch
remove review tag since long time no response.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79073|0 |1
is obsolete| |
Attachment #79074| |review?
Flags| |
--- Comment #3 from zhang jianfang <zh...@apache.org> ---
Created attachment 79074
--> https://issues.apache.org/ooo/attachment.cgi?id=79074&action=edit
refix code patch
Move these api from header file to source file and add delete action,
void SdrModel::SetColorTable(XColorTable* pTable)
void SdrModel::SetDashList(XDashList* pList)
void SdrModel::SetLineEndList(XLineEndList* pList)
void SdrModel::SetHatchList(XHatchList* pList)
void SdrModel::SetGradientList(XGradientList* pList)
void SdrModel::SetBitmapList(XBitmapList* pList)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Target Milestone|not determined |AOO 3.5.0
--- Comment #6 from zhang jianfang <zh...@apache.org> ---
Change to resolved state.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120668] SdrModel, the member objects created in
SdrModel::ImpCreateTables() leaks
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120668
--- Comment #5 from SVN Robot <sv...@dev.null.org> ---
"zhangjf" committed SVN revision 1380436 into trunk:
#i120668#, when calling SdrModel::Setxxx(), need free old object at
firstFoun...
--
You are receiving this mail because:
You are the assignee for the bug.