[GitHub] [geode] kohlmu-pivotal commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

[GitBox <gi...@apache.org>]

kohlmu-pivotal commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730081544


   > I think this violates the intent that `membership` exceptions should not escape the module
   
   @echobravopapa I love the idea that modules/components don't leak anything outside of itself. But if looking at the `DistribtionImpl` the exceptions that you don't want to leak "out", have already leaked into geode-core. So, not sure how we are trying to stop the leaking.
   
   It is not like there is even a violation of public -> internal package. The usage are in 2 internal classes.
   
   If the intent that exceptions do not escape the module, then the current implementation needs to be addressed. As the current implementation is a sieve. The exceptions have already leaked out!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org