You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/26 03:18:24 UTC

[GitHub] spark pull request #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc ex...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20401#discussion_r164027455
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java ---
    @@ -50,7 +50,7 @@ public static Trigger ProcessingTime(long intervalMs) {
        *
        * {{{
        *    import java.util.concurrent.TimeUnit
    -   *    df.writeStream.trigger(ProcessingTime.create(10, TimeUnit.SECONDS))
    +   *    df.writeStream().trigger(Trigger.ProcessingTime(10, TimeUnit.SECONDS))
    --- End diff --
    
    Since this is a java-friendly example, we had better use `writeStream()`. And, `ProcessingTime.create` shows deprecation warning.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org