You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/05/22 18:35:18 UTC
svn commit: r1126054 -
/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java
Author: simonetripodi
Date: Sun May 22 16:35:18 2011
New Revision: 1126054
URL: http://svn.apache.org/viewvc?rev=1126054&view=rev
Log:
inefficent string concatenation replaced by StringBuilder
Modified:
incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java
Modified: incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java
URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java?rev=1126054&r1=1126053&r2=1126054&view=diff
==============================================================================
--- incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java (original)
+++ incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java Sun May 22 16:35:18 2011
@@ -81,20 +81,36 @@ public abstract class ComparisonExpressi
boolean conversion = OgnlRuntime.shouldConvertNumericTypes( context );
- String result = conversion ? "(" + getComparisonFunction() + "( ($w) (" : "(";
-
- result +=
- OgnlRuntime.getChildSource( context, target, _children[0], conversion ) + " "
- + ( conversion ? "), ($w) " : getExpressionOperator( 0 ) ) + " "
- + OgnlRuntime.getChildSource( context, target, _children[1], conversion );
-
- result += conversion ? ")" : "";
+ StringBuilder result = new StringBuilder( "(" );
+ if ( conversion )
+ {
+ result.append( getComparisonFunction() ).append( "( ($w) (" );
+ }
+
+ result.append( OgnlRuntime.getChildSource( context, target, _children[0], conversion ) )
+ .append( " " );
+
+ if ( conversion )
+ {
+ result.append( "), ($w) " );
+ }
+ else
+ {
+ result.append( getExpressionOperator( 0 ) );
+ }
+
+ result.append( "" ).append( OgnlRuntime.getChildSource( context, target, _children[1], conversion ) );
+
+ if ( conversion )
+ {
+ result.append( ")" );
+ }
context.setCurrentType( Boolean.TYPE );
- result += ")";
+ result.append( ")" );
- return result;
+ return result.toString();
}
catch ( NullPointerException e )
{