You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/04/08 03:22:29 UTC
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/
-----------------------------------------------------------
(Updated April 8, 2015, 1:22 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Summary (updated)
-----------------
LENS-398: Activate enunciate only for java 6& java7
Bugs: LENS-398
https://issues.apache.org/jira/browse/LENS-398
Repository: lens
Description
-------
APT tool and its associated API were removed in JDK8.
Changes:
Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
Diffs
-----
lens-server/pom.xml 748be1d
pom.xml a5dd80f
Diff: https://reviews.apache.org/r/32951/diff/
Testing
-------
Tested by running mvn help:active-profiles and **mvn clean install**
Thanks,
Raju Bairishetti
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/#review79307
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On April 8, 2015, 5:51 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32951/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 5:51 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-398
> https://issues.apache.org/jira/browse/LENS-398
>
>
> Repository: lens
>
>
> Description
> -------
>
> APT tool and its associated API were removed in JDK8.
>
> Changes:
>
> Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
>
>
> Diffs
> -----
>
> lens-server/pom.xml 748be1d
> pom.xml a5dd80f
> tools/scripts/generate-site-public.sh 55307ee
>
> Diff: https://reviews.apache.org/r/32951/diff/
>
>
> Testing
> -------
>
> Tested by running mvn help:active-profiles and **mvn clean install**
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/
-----------------------------------------------------------
(Updated April 8, 2015, 5:51 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
removed enunciate docs from site generation script
Bugs: LENS-398
https://issues.apache.org/jira/browse/LENS-398
Repository: lens
Description
-------
APT tool and its associated API were removed in JDK8.
Changes:
Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
Diffs (updated)
-----
lens-server/pom.xml 748be1d
pom.xml a5dd80f
tools/scripts/generate-site-public.sh 55307ee
Diff: https://reviews.apache.org/r/32951/diff/
Testing
-------
Tested by running mvn help:active-profiles and **mvn clean install**
Thanks,
Raju Bairishetti
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 8, 2015, 5:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 316
> > <https://reviews.apache.org/r/32951/diff/1/?file=920393#file920393line316>
> >
> > Why is 1.8 part of this?
>
> Amareshwari Sriramadasu wrote:
> Seems open paranthesis does not include it.
Yes.. closed paranthesis does not include 1.8
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/#review79299
-----------------------------------------------------------
On April 8, 2015, 5:51 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32951/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 5:51 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-398
> https://issues.apache.org/jira/browse/LENS-398
>
>
> Repository: lens
>
>
> Description
> -------
>
> APT tool and its associated API were removed in JDK8.
>
> Changes:
>
> Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
>
>
> Diffs
> -----
>
> lens-server/pom.xml 748be1d
> pom.xml a5dd80f
> tools/scripts/generate-site-public.sh 55307ee
>
> Diff: https://reviews.apache.org/r/32951/diff/
>
>
> Testing
> -------
>
> Tested by running mvn help:active-profiles and **mvn clean install**
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 8, 2015, 5:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 316
> > <https://reviews.apache.org/r/32951/diff/1/?file=920393#file920393line316>
> >
> > Why is 1.8 part of this?
Seems open paranthesis does not include it.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/#review79299
-----------------------------------------------------------
On April 8, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32951/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 1:22 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-398
> https://issues.apache.org/jira/browse/LENS-398
>
>
> Repository: lens
>
>
> Description
> -------
>
> APT tool and its associated API were removed in JDK8.
>
> Changes:
>
> Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
>
>
> Diffs
> -----
>
> lens-server/pom.xml 748be1d
> pom.xml a5dd80f
>
> Diff: https://reviews.apache.org/r/32951/diff/
>
>
> Testing
> -------
>
> Tested by running mvn help:active-profiles and **mvn clean install**
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 8, 2015, 5:15 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 317
> > <https://reviews.apache.org/r/32951/diff/1/?file=920393#file920393line317>
> >
> > Why is explicitly set to false in lens-server pom? Can this be in main pom ? Doesnt generate-site.sh need changes to run with -Penunciate ?
Actually we can remove mvn enunciate:docs from generate-site.sh script. mvn clean package generates the rest docs as well.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/#review79299
-----------------------------------------------------------
On April 8, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32951/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 1:22 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-398
> https://issues.apache.org/jira/browse/LENS-398
>
>
> Repository: lens
>
>
> Description
> -------
>
> APT tool and its associated API were removed in JDK8.
>
> Changes:
>
> Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
>
>
> Diffs
> -----
>
> lens-server/pom.xml 748be1d
> pom.xml a5dd80f
>
> Diff: https://reviews.apache.org/r/32951/diff/
>
>
> Testing
> -------
>
> Tested by running mvn help:active-profiles and **mvn clean install**
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 32951: LENS-398: Activate enunciate only for java
6& java7
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32951/#review79299
-----------------------------------------------------------
lens-server/pom.xml
<https://reviews.apache.org/r/32951/#comment128545>
Why is 1.8 part of this?
lens-server/pom.xml
<https://reviews.apache.org/r/32951/#comment128546>
Why is explicitly set to false in lens-server pom? Can this be in main pom ? Doesnt generate-site.sh need changes to run with -Penunciate ?
pom.xml
<https://reviews.apache.org/r/32951/#comment128544>
Why is 1.8 part of this?
- Amareshwari Sriramadasu
On April 8, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32951/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 1:22 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-398
> https://issues.apache.org/jira/browse/LENS-398
>
>
> Repository: lens
>
>
> Description
> -------
>
> APT tool and its associated API were removed in JDK8.
>
> Changes:
>
> Added a new profile enunciate. This profile will be acitvated based on the running jdk environment.
>
>
> Diffs
> -----
>
> lens-server/pom.xml 748be1d
> pom.xml a5dd80f
>
> Diff: https://reviews.apache.org/r/32951/diff/
>
>
> Testing
> -------
>
> Tested by running mvn help:active-profiles and **mvn clean install**
>
>
> Thanks,
>
> Raju Bairishetti
>
>