Re: [PR] test: Move default cache tests to default cache file [datafusion]

["nuno-faria (via GitHub)" <gi...@apache.org>]

nuno-faria commented on code in PR #23040:
URL: https://github.com/apache/datafusion/pull/23040#discussion_r3447240623


##########
datafusion/execution/src/cache/default_cache.rs:
##########
@@ -294,3 +294,1692 @@ impl<K: CacheKey, V: CacheValue> Cache<K, V> for DefaultCache<K, V> {
             .collect()
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use std::sync::Arc;
+
+    use crate::cache::cache_manager::{CachedFileMetadataEntry, FileMetadata};
+    use crate::cache::default_cache::DefaultCache;
+    use crate::cache::{Cache, CacheEntryInfo};
+    use datafusion_common::HashMap;
+    use object_store::ObjectMeta;
+    use object_store::path::Path;
+

Review Comment:
   For consistency, let's move all imports here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org