You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/03/29 21:15:12 UTC
[GitHub] [nifi] phrocker commented on a change in pull request #3174:
NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
phrocker commented on a change in pull request #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
URL: https://github.com/apache/nifi/pull/3174#discussion_r270575854
##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
##########
@@ -993,6 +994,23 @@ public boolean accept(final File dir, final String filename) {
cpFiles.add(file.getAbsolutePath());
}
+ String runtimeJavaVersion = System.getProperty("java.version");
Review comment:
On my phone but since commons lang3 is in the CP, SystemUtils can help determine if a version is at least IS_JAVA_11 or IS_JAVA_10. It does the parsing for you...may not help as I can't really review super well on the phone but it's a cool utility if it applies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services