You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <Gr...@gmail.com> on 2015/08/12 23:03:54 UTC
Review Request 37414: Add sleep to TestLog.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Till Toenshoff.
Bugs: MESOS-1013
https://issues.apache.org/jira/browse/MESOS-1013
Repository: mesos
Description
-------
Fix flaky ExamplesTest.JavaLog
Diffs
-----
src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56
Diff: https://reviews.apache.org/r/37414/diff/
Testing
-------
This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try:
GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaLog" bin/mesos-tests.sh --verbose --gtest_repeat=100 2>/dev/null | grep "\["
Thanks,
Greg Mann
Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/#review95193
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37414]
All tests passed.
- Mesos ReviewBot
On Aug. 12, 2015, 9:04 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37414/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
>
>
> Bugs: MESOS-1013
> https://issues.apache.org/jira/browse/MESOS-1013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix flaky ExamplesTest.JavaLog
>
>
> Diffs
> -----
>
> src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56
>
> Diff: https://reviews.apache.org/r/37414/diff/
>
>
> Testing
> -------
>
> This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try:
>
> GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaLog" bin/mesos-tests.sh --verbose --gtest_repeat=100 2>/dev/null | grep "\["
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog
Posted by Greg Mann <Gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 9:04 p.m.)
Review request for mesos, Joris Van Remoortere and Till Toenshoff.
Changes
-------
Changed summary
Summary (updated)
-----------------
Fix flaky ExamplesTest.JavaLog
Bugs: MESOS-1013
https://issues.apache.org/jira/browse/MESOS-1013
Repository: mesos
Description
-------
Fix flaky ExamplesTest.JavaLog
Diffs
-----
src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56
Diff: https://reviews.apache.org/r/37414/diff/
Testing
-------
This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try:
GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaLog" bin/mesos-tests.sh --verbose --gtest_repeat=100 2>/dev/null | grep "\["
Thanks,
Greg Mann