You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by nikste <gi...@git.apache.org> on 2015/06/03 15:31:37 UTC
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/768
[FLINK-2126] Fixed Flink scala shell ITSuite sporadic failures
Add-numbers from 1..10 now does not check for "Job execution switched to status FINISHED.", which sometimes was not printed.
Fixed typo in add numbers test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikste/flink Scala_shell_ITSuite_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #768
----
commit 267714126a606076b44e45c7e55be1f1d2fed996
Author: Nikolaas Steenbergen <ni...@googlemail.com>
Date: 2015-06-03T10:39:02Z
Add-numbers from 1..10 now does not check for "Job execution switched to status FINISHED.", which sometimes did not show up.
Fixed typo in add numbers test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108808536
...merge race :D Can you change the commit msg to include the issue ID please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108808452
+1
Having the correct result is the main validation we need.
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108527888
Can you just remove the commented lines? And I think that we should also remove the check from the other tests.
From @tillrohrmann: the issue with the LOG file not being created is a separate issue. Till, do we have an issue for that one? Is this the only tests, which runs with scalatest or why does it not affect other tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by nikste <gi...@git.apache.org>.
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108780565
Ok, removed the comments and the "Job execution switched to status FINISHED." for all tests now (although, till now it only happened in the "add numbers" Tests.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108772594
We haven't created an issue for the logging file, yet. Will do. The
flink-scala-shell and the flink-ml modules use the scalatest maven plugin.
The fix should be easy, though. Simply give these two modules a different
travis log4j properties file where you don't depend on the fork number.
On Wed, Jun 3, 2015 at 7:13 PM, Ufuk Celebi <no...@github.com>
wrote:
> Can you just remove the commented lines? And I think that we should also
> remove the check from the other tests.
>
> From @tillrohrmann <https://github.com/tillrohrmann>: the issue with the
> LOG file not being created is a separate issue. Till, do we have an issue
> for that one? Is this the only tests, which runs with scalatest or why does
> it not affect other tests?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/768#issuecomment-108527888>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/768
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2126] Fixed Flink scala shell ITSuite s...
Posted by nikste <gi...@git.apache.org>.
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108823811
Changed to include the issue ID, 3..2..1 GO !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---