[GitHub] [netbeans] neilcsmith-net removed a comment on pull request #2417: (Re)enable building netbeans offline

[GitBox <gi...@apache.org>]

neilcsmith-net removed a comment on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703753091


   > The approach to download the json file to some "build" directory will not work. ant clean will clean the build directory and your offline buildability is gone.
   
   @matthiasblaesing I actually said `nbbuild/` not `nbbuild/build/`.  Check the source zip releases - they have two extra files in there - `gitinfo.properties` and `netbeansrelease.properties` to ensure consistent builds.  Copying those from `nbbuild/build/` to `nbbuild/` should allow this to work offline (and if it doesn't that's a bug I think).
   
   Agree with @ebarboni this is OK to merge, but do think we should look at using the above mechanism (or extension of it) in a latter PR, in place of your instructions here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists