You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/25 23:13:25 UTC
Review Request 14944: Fixed GarbageCollectorIntegrationTest.ExitedFramework
test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14944/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-777
https://issues.apache.org/jira/browse/MESOS-777
Repository: mesos-git
Description
-------
See bug.
Diffs
-----
src/slave/slave.cpp 7991e41b6f660a6e58d7fcc84df3449a3ecf8320
src/tests/gc_tests.cpp 4376ebade32a9c6b91e260cff1e971c54d85cb1a
Diff: https://reviews.apache.org/r/14944/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*ExitedFramework*" --verbose
Thanks,
Vinod Kone
Re: Review Request 14944: Fixed
GarbageCollectorIntegrationTest.ExitedFramework test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14944/#review27552
-----------------------------------------------------------
Ship it!
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/14944/#comment53475>
Can you mention that this is because of the race between starting the executor and telling the slave that it's started? That is, it's possible for the executor to send a status update before the slave gets notified that it's started.
(We should try to make this impossible, I think the new Launcher Ian is working on may help with this).
- Ben Mahler
On Oct. 25, 2013, 9:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14944/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 9:13 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-777
> https://issues.apache.org/jira/browse/MESOS-777
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7991e41b6f660a6e58d7fcc84df3449a3ecf8320
> src/tests/gc_tests.cpp 4376ebade32a9c6b91e260cff1e971c54d85cb1a
>
> Diff: https://reviews.apache.org/r/14944/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*ExitedFramework*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>