You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2020/05/02 21:13:21 UTC
[maven-wagon] branch master updated: Add TODOs and FIXMEs
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
The following commit(s) were added to refs/heads/master by this push:
new 6966aff Add TODOs and FIXMEs
6966aff is described below
commit 6966aff550f96f3664c10f2802ff315aeb21f412
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat May 2 23:12:46 2020 +0200
Add TODOs and FIXMEs
---
.../org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java | 1 +
.../java/org/apache/maven/wagon/shared/http/HttpConfiguration.java | 4 ++--
.../java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java | 4 ++++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index e8a9405..51d24cf 100644
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -775,6 +775,7 @@ public abstract class AbstractHttpClientWagon
// preemptive for put
// TODO: is it a good idea, though? 'Expect-continue' handshake would serve much better
+ // FIXME Perform only when preemptive has been configured
Repository repo = getRepository();
HttpHost targetHost = new HttpHost( repo.getHost(), repo.getPort(), repo.getProtocol() );
AuthScope targetScope = getBasicAuthScope().getScope( targetHost );
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java
index 34fc61c..0a8652c 100644
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java
@@ -25,11 +25,11 @@ import org.apache.http.client.methods.HttpPut;
import org.apache.http.client.methods.HttpUriRequest;
/**
- *
+ *
*/
public class HttpConfiguration
{
-
+
private static final HttpMethodConfiguration DEFAULT_PUT =
new HttpMethodConfiguration().addParam( "http.protocol.expect-continue", "%b,true" );
diff --git a/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java b/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
index 9460875..2aac440 100644
--- a/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
+++ b/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
@@ -155,6 +155,10 @@ public class WebDavWagon
private int doMkCol( String url )
throws IOException
{
+ // preemptive for mkcol
+ // TODO: is it a good idea, though? 'Expect-continue' handshake would serve much better
+
+ // FIXME Perform only when preemptive has been configured
Repository repo = getRepository();
HttpHost targetHost = new HttpHost( repo.getHost(), repo.getPort(), repo.getProtocol() );
AuthScope targetScope = getBasicAuthScope().getScope( targetHost );