[GitHub] [pinot] PrachiKhobragade commented on a change in pull request #8422: Change TableDataManger deletion to message based

[GitBox <gi...@apache.org>]

PrachiKhobragade commented on a change in pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#discussion_r838994387



##########
File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentMessageHandlerFactory.java
##########
@@ -58,6 +59,8 @@ public MessageHandler createHandler(Message message, NotificationContext context
         return new SegmentRefreshMessageHandler(new SegmentRefreshMessage(message), _metrics, context);
       case SegmentReloadMessage.RELOAD_SEGMENT_MSG_SUB_TYPE:
         return new SegmentReloadMessageHandler(new SegmentReloadMessage(message), _metrics, context);
+      case TableDeletionMessage.DELETE_TABLE_MSG_SUB_TYPE:
+        return new TableDeletionMessageHandler(new TableDeletionMessage(message), _metrics, context);

Review comment:
       Does this need a new TableDeletionMessage or the current message can be just cast to it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org