[GitHub] [spark] turboFei removed a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

[GitBox <gi...@apache.org>]

turboFei removed a comment on issue #24992:  [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements
URL: https://github.com/apache/spark/pull/24992#issuecomment-507135803
 
 
   @maropu 
   It is difficult to judge Set(currentOrderOfKeys) == Set(expectedOrderOfKeys).
   For example:
   ```
   Seq(1, 2, 2, 2) 
   Seq(1, 1, 2, 2)
   Seq(1, 1, 1, 2) 
   ```
   So I add a judgement in `reorder`, when we can not reorder the join keys, return the (leftKeys, rightKeys) directly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org