[jira] [Commented] (FLINK-8726) Code highlighting partially broken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371362#comment-16371362 ] 

ASF GitHub Bot commented on FLINK-8726:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5497#discussion_r169626782
  
    --- Diff: docs/dev/migration.md ---
    @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction<Tuple2<String, Integer>>,
             bufferedElements.add(value);
             if (bufferedElements.size() == threshold) {
                 for (Tuple2<String, Integer> element: bufferedElements) {
    -	        // send it to the sink
    -	    }
    -	    bufferedElements.clear();
    -	}
    +            // send it to the sink
    +        }
    +        bufferedElements.clear();
    --- End diff --
    
    hmm, it should be `{% highlight java %}`, in particular since [FLINK-8726](https://issues.apache.org/jira/browse/FLINK-8726) popped up.


> Code highlighting partially broken
> ----------------------------------
>
>                 Key: FLINK-8726
>                 URL: https://issues.apache.org/jira/browse/FLINK-8726
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> With the recent changes around the documentation build dependencies code highlighting is no longer fully working.
> Sections as below are rendered without any background [like here|https://ci.apache.org/projects/flink/flink-docs-master/dev/stream/operators/windows.html].
> {code}
> ~~~bash
> # get the hadoop2 package from the Flink download page at
> # {{ site.download_url }}
> curl -O <flink_hadoop2_download_url>
> tar xvzf flink-{{ site.version }}-bin-hadoop2.tgz
> cd flink-{{ site.version }}/
> ./bin/flink run -m yarn-cluster -yn 4 -yjm 1024 -ytm 4096 ./examples/batch/WordCount.jar
> ~~~
> {code}
> Sections using the {{\{% highlight java %}}} syntax are still working.
> We may have to do a sweep over the docs and port all code sections to the working syntax.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)