You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/21 02:55:21 UTC
[GitHub] [phoenix] stoty commented on pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
stoty commented on pull request #913:
URL: https://github.com/apache/phoenix/pull/913#issuecomment-731496674
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 54s | 4.x passed |
| +1 :green_heart: | compile | 1m 32s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 53s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 23s | 4.x passed |
| +0 :ok: | spotbugs | 0m 26s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 23s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 23s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 25s | root in 4.x has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 57s | phoenix-core in 4.x has 950 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 36s | the patch passed |
| +1 :green_heart: | cc | 1m 36s | the patch passed |
| +1 :green_heart: | javac | 1m 36s | the patch passed |
| -1 :x: | checkstyle | 3m 0s | root: The patch generated 330 new + 8319 unchanged - 76 fixed = 8649 total (was 8395) |
| +1 :green_heart: | prototool | 0m 2s | There were no new prototool issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 28s | the patch passed |
| -1 :x: | spotbugs | 3m 29s | phoenix-core generated 4 new + 950 unchanged - 0 fixed = 954 total (was 950) |
| -1 :x: | spotbugs | 4m 36s | root generated 4 new + 1004 unchanged - 0 fixed = 1008 total (was 1004) |
||| _ Other Tests _ |
| -1 :x: | unit | 195m 56s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 22s | The patch does not generate ASF License warnings. |
| | | 259m 36s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be At IndexRegionObserver.java:be At IndexRegionObserver.java:[line 126] |
| | org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be At IndexRegionObserver.java:be At IndexRegionObserver.java:[line 125] |
| | Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long) At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long) At IndexRegionObserver.java:[line 800] |
| | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] |
| FindBugs | module:root |
| | org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be At IndexRegionObserver.java:be At IndexRegionObserver.java:[line 126] |
| | org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be At IndexRegionObserver.java:be At IndexRegionObserver.java:[line 125] |
| | Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long) At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long) At IndexRegionObserver.java:[line 800] |
| | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] |
| Failed junit tests | phoenix.end2end.index.ViewIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/913 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml |
| uname | Linux 88e7da627350 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / e57fcc8 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/testReport/ |
| Max. process+thread count | 6080 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org