You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/09 11:38:31 UTC

[GitHub] [kafka] AshishRoyJava commented on pull request #8633: KAFKA-9965: Incrementing counter cause uneven distribution with RoundRobinPartitioner

AshishRoyJava commented on pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#issuecomment-626161764


   > Nice finding! Could you add tests for this fix?
   
   I was unable to modify the existing test methods. This `RoundRobinPartitioner#onNewBatch` is not being used anywhere in the existing test methods, hence there was no scope to check.
   The `onNewBatch` overridden method only decrementing the counter in the map, so it needs to be tested from a method where it is being called.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org