You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/17 13:24:51 UTC

[GitHub] [superset] stephenLYZ commented on a diff in pull request #20099: Add cypress test for report page direct link issue

stephenLYZ commented on code in PR #20099:
URL: https://github.com/apache/superset/pull/20099#discussion_r874809816


##########
superset-frontend/cypress-base/cypress/integration/alerts_and_reports/alert_report.helper.ts:
##########
@@ -0,0 +1,2 @@
+export const ALERT_LIST = '/alert/list/';

Review Comment:
   Need to add a License.



##########
superset-frontend/cypress-base/cypress/integration/alerts_and_reports/reports.test.ts:
##########
@@ -0,0 +1,26 @@
+import { REPORT_LIST } from './alert_report.helper';

Review Comment:
   same here.



##########
superset-frontend/cypress-base/cypress/integration/alerts_and_reports/alerts.test.ts:
##########
@@ -0,0 +1,26 @@
+import { ALERT_LIST } from './alert_report.helper';

Review Comment:
   same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org