[sling-org-apache-sling-discovery-oak] 03/07: SLING-6065 : removed unnecessary log.error which is actually a legitimate case at startup

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to annotated tag org.apache.sling.discovery.oak-1.2.12
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-discovery-oak.git

commit 233d6c52e47facba4cd40e8fcd8e493837a95555
Author: Stefan Egli <st...@apache.org>
AuthorDate: Wed Sep 21 14:32:41 2016 +0000

    SLING-6065 : removed unnecessary log.error which is actually a legitimate case at startup
    
    git-svn-id: https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/discovery/oak@1761753 13f79535-47bb-0310-9956-ffa450edef68
---
 .../java/org/apache/sling/discovery/oak/pinger/OakViewChecker.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/sling/discovery/oak/pinger/OakViewChecker.java b/src/main/java/org/apache/sling/discovery/oak/pinger/OakViewChecker.java
index 4dd9e22..88c320d 100644
--- a/src/main/java/org/apache/sling/discovery/oak/pinger/OakViewChecker.java
+++ b/src/main/java/org/apache/sling/discovery/oak/pinger/OakViewChecker.java
@@ -313,7 +313,12 @@ public class OakViewChecker extends BaseViewChecker {
 
     protected void updateProperties() {
         if (discoveryService == null) {
-            logger.error("issueHeartbeat: discoveryService is null");
+            // SLING-6065: it's legitimate that updateProperties()
+            // (which comes from BaseViewChecker.issueHeartbeat())
+            // is called while discoveryService is not yet set. That's 
+            // due to the fact that discoveryService is set in initialize()
+            // which is called once the OakDiscoveryService is activated
+            // and that can come at a later point.
         } else {
             discoveryService.updateProperties();
         }

-- 
To stop receiving notification emails like this one, please contact
"commits@sling.apache.org" <co...@sling.apache.org>.