[GitHub] [spark] cloud-fan commented on a change in pull request #31860: [SPARK-34770][SQL] InMemoryCatalog.tableExists should not fail if database doesn't exist

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31860:
URL: https://github.com/apache/spark/pull/31860#discussion_r595726401



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
##########
@@ -704,6 +704,9 @@ abstract class SessionCatalogSuite extends AnalysisTest with Eventually {
       catalog.createTempView("tbl3", tempTable, overrideIfExists = false)
       // tableExists should not check temp view.
       assert(!catalog.tableExists(TableIdentifier("tbl3")))
+
+      // Id database doesn't exist, return false instead of failing.
+      assert(!catalog.tableExists(TableIdentifier("tbl1", Some("non-exist"))))

Review comment:
       Before this PR, this test passes in `HiveExternalSessionCatalogSuite`, but fails in `InMemorySessionCatalogSuite`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org