You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/10/23 07:33:50 UTC

[PR] [fix](storage) Fix reading a rowset whose segments overlap on keys [doris]

csun5285 opened a new pull request, #69513:
URL: https://github.com/apache/doris/pull/69513

    1. `LazyInitSegmentIterator` did not override `data_id()` (since #35432), so  
     the segment merge                                                             
        could not tell which segment is newer and kept the **older** row of a key. 
     2. `VCollectIterator::Level0Iterator::next()` read the same-key bit of the    
     next row before moving                                                        
        to the next Block, so every key group cut by a Block boundary was folded   
     **twice**.                                                                    
     3. A sequence-map table needs every row of a key, but `TabletReader` still    
     asked the segment merge                                                       
        to keep only the newest row (`is_unique`), so a column group whose largest 
     sequence value was                                                            
        in the other segment **lost its values** (#54936). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](storage) Fix reading a rowset whose segments overlap on keys [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69513:
URL: https://github.com/apache/doris/pull/69513#issuecomment-6359901409

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org